Themed Jokers!

[vast ledge]

Themed Jokers

This mod is a remake of Blizzow's Themed Jokers.

Installation

If you have Git installed, open a terminal in your Mods folder and type git clone https://github.com/cerloCasa/Themed-Jokers.git
Alternatively, you can go to the main page and click on the green "<> Code" button, then "Download ZIP", extracting the downloaded file and moving the Themed-Jokers-main folder into your Mods folder.

Additions

Combat Aces

• 8 Jokers
• 1 Tarot
• 1 Deck

Cosmic

• 13 Jokers
• 3 Tarots
• 1 Deck

Mischievous

• 6 Jokers
• 1 Tarot
• 1 Deck

Omen

• 6 Jokers

[frail trout]

ooo

neat!

[vast ledge]

Huge thanks to @shut ether for this mod, I simply ported it to steamodded 1.0

[frail trout]

hell yeah

[shut ether]

good job

[vast ledge]

and added art for the three decks because they NEEDED one 🤣

[magic plinth]

Wow

Does recruiter bug fixed? Or you simply ported it

[vast ledge]

which was the bug? I rewrote many Jokers from scratch

[magic plinth]

#1255696773599592458 message

[vast ledge]

I tested it and it works, so I think that the bug is now solved

[magic plinth]

🔥

I will go ahead and test it out

[vast ledge]

recruiter used some 0.9.8 code which now doesn't work anymore

OOPS I left the debug option to true

just go into the main file and change it to false

fixing it now...

ok fixed it 👍

[magic plinth]

So omens are removed?

[vast ledge]

yeah i didn't add them yet

do you want them?

[vast ledge]

unfortunately I think that part is also incomplete in the original version, right @shut ether?

[shut ether]

yea im reworking them once 1.0 is out of alpha

[magic plinth]

Don't worry about it, just wanna make sure it's intended

[vast ledge]

for now, I'm adding the ones you already made

[vast ledge]

also, what are these?

[shut ether]

other artwork for cosmics

[vast ledge]

VERSION 1.1 IS OUT

I have added the 6 Omen Jokers

[vast ledge]

@magic plinth

[magic plinth]

Thanks 🙏

[vast ledge]

can you please update the https://discord.com/channels/1116389027176787968/1260833176935465063 ?

[magic plinth]

Where do I need to fix?

[vast ledge]

the mod adds 6 more jokers

[magic plinth]

I didn't revise the joker count so if the omen jokers are added it should be correct

[vast ledge]

@magic plinth wait, I found a bug

i'm fixing it now

just wait for the V1.2 to come out

[noble vessel]

I tried choosing this card - game crashed. I tried disabling rest of the mods - it crashes too

[noble vessel]

very interesting mod anyway 😄

[vast ledge]

strange... it works for me

can you give me the crash message?

[noble vessel]

Sure, I will send it later

[scenic hill]

hey! loving this mod but i have been having some issues with the cultist of the mischievous one
is it only suposed to repeatedly give you the first piece? because no matter what i do i can't get it to give me any other piece

update: my bad, turns out i just hadn't had them discovered yet

wait no they're always unlocked

is there something screwy with the cultist code because it literally will not give me antyhing except piece 1

[vast ledge]

i'll look into that

[vast ledge]

fixed and uploaded

[scenic hill]

so just in the most recent github upload?

did a rapid test, newest patch works as intended! thanks for checking it out

[noble vessel]

I forgot that I already chose something else in this arcane pack but I tried using debug mod, spawned this card and everything was working fine

oh, and finally I beat a white stake in this deck, cool mod!

Oh, now I have another bug - in "Cosmic" deck I don't get any tarot cards

I mean these guaranteed

[vast ledge]

fixed it and pushed it

[vast ledge]

Fixed a bug that let you spawn an Ophiuchus even if you already had one, updated The Sign's text

[sick portal]

An error appears when I hover on "The sign" on the collection.

[magic plinth]

Also this

#1255696773599592458 message

[vast ledge]

oops

I'm not at home, gonna fix it tonight

[vast ledge]

you sure you updated to the last commit? also gonna check this

[sick portal]

I download the source code (v1.3) today.

[vast ledge]

Fixed the bugs

Just go to the mod page and download the main branch

[vast ledge]

@gusty elbow can you pin please?

[gusty elbow]

It's stuck to the left

[eager canopy]

I liked this mod a lot back in .98 and I'm happy to see it back and really happy the decks have art now! Thanks!

[vast ledge]

Added compatibility with https://discord.com/channels/1116389027176787968/1279246553931976714

[pure arch]

jimbo the mischevious one became +9 instead of x9 after i ankh'd it lol, is this intended?

it might have been +9 even before that i wasn't paying attention tbh

yeah started a new run its also +6 instead of x6 when first created haha

[magic plinth]

#1255696773599592458 message

Maybe you can take a look at this?

[vast ledge]

i'll look into that

[vast ledge]

that's not an issue by this mod as I don't hook into the game code

[vast ledge]

found the bug

[pure arch]

i just fixed it locally too lol, mult_mod was used instead of Xmult_mod it looks like

fun mod, wouldn't have found it without the port. thanks

[vast ledge]

Fixed it

[vast ledge]

yeah lol I opened the file of the Joker and saw "mult_mod" in the first 2 seconds ahaà

[pure arch]

crash on using create combat ace tarot card

[pure arch]

fixed. typo in Contract.lua

[5] = 'j_Themed_CA-Secret Agent',
extra space here^
[5] = 'j_Themed_CA-SecretAgent',

[pure arch]

another crash, winning on combat ace deck (with combat ace sleeve)

[pure arch]

restarted the game and it seems to be working now, not sure how to reproduce the problem. i did sell a negative veteran joker (debuffed) before winning this time but i can't imagine that is related

[frail pollen]

Love that! 💙

[frail pollen]

This seems to be a steamodded bug btw, not any singular mod's fault

[pure arch]

yeah, i looked at it a bit myself and wasn't sure what was happening, i imagine its bugged because there wasn't a catch to see if wins_by_key existed on deck_wins but it for some reason self corrected after restarting the game

[vast ledge]

fixed it, thanks

[idle wave]

Hey, just gave this a try. Are the cosmic tokens supposed to count retroactively? Just picked these up for the first time in the shop and they both read 0 but with stacks on them

Maybe they just start off as 20% and +3? 😅

[magic plinth]

I *think* they are not supposed to be like that, I used the original version

But I don't remember clearly

[idle wave]

playing a 4 the round after gave the first one +1 and the second read 0 and 1 total so that seem to work as intended at least

[magic plinth]

So it should be fine but a visual bug

[idle wave]

just came across one in shop, so at least this is how it looks for me at base. Its the same in collection so that is probably just how they're supposed to be when first purchased 👍

This was interesting though, I got my hands on two cultists and finished a round with 1 of each piece and the two of them. Looks like they both spawned a jimbo but only one of them destroyed itself 😆

https://tenor.com/view/its-free-real-sate-gif-7215175

[vast ledge]

they don't count retroactively, they just start at 20% and 3

[idle wave]

I really like the idea of the cosmic tokens btw, super cool mechanic for this game. Maybe a little powerful in my opinion and the themes take up a lot of spots in the tarot packs but I enjoyed playing around with it! Really nice work and the cosmic pack specifically feels like the best and well implemented 🙂

[vast ledge]

that wasn't in my testcases lol

[idle wave]

For me I just happened to find the cultist early in a shop, and the next arcana had the 50/50 to spawn a cultist/piece. But even with just the tarot + fool for example it could be pretty common. So with just 6 slots it's doable and goes wild haha. With the cultist left behind, the one piece spawned also feeds both jimbos so they go through the roof immediately

The cultist joker is really cool but I don't think it needs the tarot really since it's a tarot slot that pretty much guarrantees him every run. I think it could be okay with the cultist simply surviving so you don't need to be super lucky and find another one after, it still an awesome standalone joker as it is. You still need to take the time to get all the pieces, and have 5 spaces free in the end to spawn the jimbo. So the later you'd pick it up it would be riskier if you can hold on and selling of old jokers until you get it 👍

And after that have money to hopefully refill with new jokers ofc

[vast ledge]

ok I managed to understand what happens

both Cultist try to delete all parts and the Cultist to the left

[vast ledge]

fixed it

[idle wave]

I don't play with this activated anymore because to me it's a bit too disruptive to have so many tarot slots being taken up by cards aimed at a few specific jokers but as I said you got some really nice ideas going and the mechanic of cosmic tokens are super slick implemented both gameplay and visually so this is all said with love and not critique! 😉

If the cosmics where ever separated as their own additions/mod I'd love to add them and keep as part of the few mods I have. This is a bigger change so I understand if it's not on the table at all, but I'd also think simply having the cosmic jokers in the pool (it's one for every card rank right? Also super cool design from you) and no extra tarots at all, would be better in my mind.
For example the retrigger cosmic with +0.5% retrigger still gets +2% for every 4 of a kind played with that rank, so at least the cosmics I came across all seemed like fun and powerful scaling as is even without the boosts from tarots, and it also forces the player to actually score the cards related to the jokers which is a fun way to shape/incentivize the run for bigger benefits.

Didn't get the "150 total tokens negative spawn" thing so I don't know exactly what that joker is, but maybe instead of a tarot needed to trigger the effect/spawn, all the rare cosmic jokers could have the inherent effect of "if totalt tokens are more than 50,60,70 (or whatever could be the best balance) when selecting blind, spawn the negative card". Or maybe even all the cosmics could have something like that which makes you want to try to stack them immediately if possible, even if that perticular effect doesn't do much for your current run. Keep up the good work!

[vast ledge]

thanks a lot for the feedback ❤️ remember that this is only a port of Themed Jokers by @shut ether for 0.9.8, and I didn't change any of the card effects. Anyway, you can go into the main file of the mod and you'll find a config table where you can put everything but Cosmic on false and those Jokers and tarots won't be loaded.

[idle wave]

Oh right! I remember reading that on the git lol 😄

Cool, I might do that! Thanks a lot for the tip!

And all my praises for the gameplay and mechanic design of course goes for the original creator as well so amazing stuff Blizz ❤️ But porting it so people have the chance to try it out is still nothing to scoff at so thanks for that too 👍

[sick portal]

@vast ledge error occurs after updating SMOD to 1006a

[wary bluff]

Hi, Combat Ace Recruiter will have issues with mod added suits. You can replace "string.sub(_card.base.suit, 1, 1)" with SMODS.Suits[_card.base.suit].card_key" or look into SMODS change_base function.

[magic plinth]

You mean this?

[wary bluff]

yes

[magic plinth]

Replace with SMODS.Suits[oldcard.base.suit].card_key. ?

[wary bluff]

local newCard = SMODS.Suits[oldCard.base.suit].card_key .. '_A'

you can take a look at my mod fixes mod, I have it fixed there

[magic plinth]

Ok

[mint temple]

So @vast ledge how big can the numbers get before breaking?

And why does the effects of the cosmic cards retrigger every 100%