austere elm
tired of the Illusion voucher lying to you and not generating seals? me too! i fixed that! should work with modded seals!
https://github.com/rileyinman/BetterIllusion
i'm also workshopping a more comprehensive rework of the Magic Trick and Illusion vouchers in the dev branch, so check it out and let me know if you have any feedback :)
note, the current seal chance is set to the same as the vanilla edition chance, but does a separate check so you can end up with a seal on cards with or without editions
austere elm
no problem! yeah, there's just no code in the game to actually generate seals on the card haha
limpid sable
this is very good, definitely will be taking Illusion more often now
solid zinc
There is a poll seals function in smods that will let you use seal weights accordingly for this btw
austere elm
oh excellent, i'll make a change to use that instead
solid zinc
also means that if there are modded seals that people only want to be obtained in a certain way it'll ignore them as long as they use in_pool/weights correctly
austere elm
also makes sense!
i'm not sure if it'll have to be a separate mod, but i'm also considering having the option to "enhance" magic trick/illusion since i know a lot of people think that it's too weak
still just concepting it though
austere elm
austere elm
picture concept from @marsh wadi that i may try to add to this mod later:
marsh wadi
👍
austere elm
alright, work in progress... if they live in the main area instead of a popout, then the cards will have to overlap if i give it two slots
there's just not enough room
having to deal with overstock influencing the space as well
slender latch
I really think the shelf idea would be for the best.
austere elm
alright, work in progress... if they live in the main area instead of a popout, ...
@timber hamlet i think it was you that suggesting adding them in the main shop area, with overstock plus i think it's still a bit too crowded after tweaking
austere elm
I really think the shelf idea would be for the best.
i haven't decided against it, just started out by doing it this way so i could test the card spawning behavior first and build the mod up
slender latch
i haven't decided against it, just started out by doing it this way so i could t...
Makes complete sense.
austere elm
this is the best i've gotten so far, i may need to ask for help figuring out the ui code here
i think the issue is that this would need to be outside the bounding box of the entire main shop area, but i just don't know enough to properly do that
i'm doing this by patching functions/UI_definitions.lua, the one you see above is injected as a second node in the shop's UIBox_dyn_container (right above the closing }, false))
slender latch
I could maybe take a crack at it later.
austere elm
i'll let you know if i don't figure it out, i might be able to get it
and much appreciated
oh hi over there
lol
feels like i'm close... i just need to figure out why it's all the way over there and make it stop doing that
slender latch
What's your code for it at?
Assuming it's aligned to cl at the moment, could maybe just have it aligned to cm and put a large clear colored spacer on the left side of it.
austere elm
i just got it, was actually the other way around!
i was aligning cm but needed to align cl
now i need to make it blend in a bit better
twilit ivy
<@454101940289142794> i think it was you that suggesting adding them in the main...
might be cool to have this UI as an option, too, since some mods add UI in the area that the playing cards would be situated
austere elm
damn, still not enough room without the cards overlapping
austere elm
might be cool to have this UI as an option, too, since some mods add UI in the a...
i can try to make that an option once i've got this nailed down!
while you're here, any suggestions about my space woes? 😛
twilit ivy
I think making both a little smaller and dealing with a bit of overlap is fine
in Cryptid, where it is pretty easy to get overlapping cards with extra overstocks, it doesn't really become a major issue until 10+ cards
twilit ivy
picture concept from <@213102198601547776> that i may try to add to this mod lat...
or this concept could work
austere elm
hmm yeah, i think i discounted the option of moving the vouchers because i'm hung up on making this feel relatively vanilla
twilit ivy
in that case, you may need to compress them or make the cards themselves smaller
slender latch
I think I'd rather have a tiny bit of overlap than moving the vouchers, especially if it only moves after picking up Magic Trick.
twilit ivy
both of which would look awkward compared to vanilla
austere elm
I think I'd rather have a tiny bit of overlap than moving the vouchers, especial...
right, that's mostly my line of thinking
having a voucher move the voucher section seems a bit weird
austere elm
in that case, you may need to compress them or make the cards themselves smaller
one sec, i had them overlapping a minute ago...
slender latch
Could make it 1 card, and Illusion lets rerolls affect it?
Might require a bit more of a buff to counteract the downsides not having rerolls automatically affect it, but I don't think it's completely unquestionable.
austere elm
i already got rerolls working on it, so i could definitely code it to do that
slender latch
They're usually only $1, right?
austere elm
austere elm
They're usually only $1, right?
the game auto-calculates the card cost based on if it has edition/enhancement/seal i believe
standard cards are $1
slender latch
Can you throw some combination of seals/editions/enhancements on those, see how readible they are at a glance?
austere elm
yeah sure, gimme one sec
not bad, but still feels a bit off
and i'll figure out why the costs are so low later
marsh wadi
Seems like seals and enhancements just aren't affecting prices
austere elm
yeah, most likely
i'll trawl through the code and hook into it properly after i get ui completely sorted
marsh wadi
Have you considered
And this is a lil radical
But have you considered shifting the whole shop over to the left a lil
To make space
slender latch
I think it'd feel uncomfortable for most people that are used to Balatro.
slender latch
I think this'll work perfectly fine, considering seals are on the left.
austere elm
it would make the spacing between the deck and the left bar uneven, which i don't tihnk would work right
marsh wadi
Another option which could look stupid but idk is rotating the cards 90°
slender latch
I think it'd fit and look better, but impair readability.
austere elm
I think this'll work perfectly fine, considering seals are on the left.
i guess it comes down to what is better for balance:
OR
at least, those are the ideas i've got in my head now
feel free to suggest others
slender latch
Those were my options as well, specifically the "and" for Illusion, though.
marsh wadi
I figured playing cards would reroll with the shop
austere elm
that's a fair point, players will probably assume that the card will reroll unless it's indicated otherwise
slender latch
I figured playing cards would reroll with the shop
Since you'd be guaranteed to 100% find a playing card since there's a specific space for it, it wouldn't matter as much as it does at the moment.
slender latch
that's a fair point, players will probably assume that the card will reroll unle...
You'll be changing the voucher up anyways, one more line mentioning no rerolls probably wouldn't hurt. But I am still split 50/50.
austere elm
true!
slender latch
Alternatively, magic trick could give something like 2 rerolls, while Illusion allows infinite?
I think you could squeeze text in there to the left of it to show rerolls remaining, like how the Ante 1 Voucher has text in the voucher area.
austere elm
wouldn't it either be 0 or "as many as you have money" though?
unless you're suggesting to add a separate limit to the rerolls on the cards
oh wait i missed your message
i would do a poll but i feel like there's not yet enough interest in this mod to get a good distribution
slender latch
Yeah.
slender latch
Another option which could look stupid but idk is rotating the cards 90°
Kind of considering if there might be a way to slightly tilt them, or maybe stagger them, or do something like make one slightly lower than the other, possibly even do something like when you have a Tier 1 and 2 voucher, but that'd probably require touching card align code, and that's a whole other mess.
austere elm
while i let the different ideas brew i'm gonna mess with the ui a bit more
any clue why the two cards are offset slightly to the right? i want to fix that regardless of if there's one or two cards
i think it's something with the cardarea...
slender latch
Is the card area itself aligned to cl?
The alignments align the contents inside, not the elements themselves.
austere elm
ah i see, lemme check
right now i have:
function create_shop_cards_area()
return ({n=G.UIT.R, config={align = "cl"}, nodes={
{n=G.UIT.R, config={align = "cm", padding = 0.05, r = 0.1, colour = G.C.DYN_UI.MAIN}, nodes={
{n=G.UIT.R, config={align = "cm", padding = 0.05, r = 0.1, colour = G.C.BLACK}, nodes={
{n=G.UIT.C, config={align = "cm", padding = 0.2, r=0.2, colour = G.C.L_BLACK, minw = 4.2}, nodes={
{n=G.UIT.O, config={align = "cl", object = G.shop_playing_cards}}
}}
}}
}}
}})
end
so the outermost container is aligned center left and so is the object, setting it to cm doesn't change anything
marsh wadi
What are the odds for edition/seal/enhancements in a standard pack?
austere elm
looks like there's a CardArea:align_cards() function, maybe that's the trick
austere elm
What are the odds for edition/seal/enhancements in a standard pack?
not sure but i can check
ah no, align_cards() is just to make sure multiple cards in an area line up
slender latch
Changing that top cl sends it off screen, right?
slender latch
Does seem odd, but the UI can definitely be weird.
I'm using this image for reference, not really seeing the G.C.BLACK, but might be because it's simply too thin.
austere elm
What are the odds for edition/seal/enhancements in a standard pack?
40% enhancement chance, 1.2% polychrome chance, 4% holographic chance, 8% foil chance
and the poly/holo/foil chance scales with hone and glow up
austere elm
I'm using this image for reference, not really seeing the G.C.BLACK, but might ...
lemme get you an updated picture
i added the black after that
slender latch
I'm using this image for reference, not really seeing the G.C.BLACK, but might ...
Can you set that minw in the .C to 3 and 5 for testing?
marsh wadi
40% enhancement chance, 1.2% polychrome chance, 4% holographic chance, 8% foil c...
What about seals?
slender latch
What about seals?
Vanilla didn't generate seals, that's what made this mod originally.
austere elm
What about seals?
would require more calculation, not sure
austere elm
Vanilla didn't generate seals, that's what made this mod originally.
the question was about standard packs, not the shop :P
packs generate seals pretty sure
slender latch
Oh, yeah, missed that.
marsh wadi
Vanilla didn't generate seals, that's what made this mod originally.
Nah I mean in standard packs
Oh well there ya go
slender latch
right now i have:
```
function create_shop_cards_area()
return ({n=G.UIT.R, ...
Try plugging this in, maybe? Just a wild guess.
function create_shop_cards_area()
return ({n=G.UIT.R, config={align = "cl"}, nodes={
{n=G.UIT.R, config={align = "cl", padding = 0.075, r = 0.1, colour = G.C.DYN_UI.MAIN}, nodes={
{n=G.UIT.R, config={align = "cm", padding = 0.075, r = 0.1, colour = G.C.BLACK}, nodes={
{n=G.UIT.C, config={align = "cm", padding = -0.2, r=0.2, colour = G.C.L_BLACK, minw = 4.2}, nodes={
{n=G.UIT.O, config={align = "cl", object = G.shop_playing_cards}}
}}
}}
}}
}})
end
sure!
it's had some effect, but still misaligned
looks like the parent object this is all inside is also aligned cl
not sure if that matters
slender latch
Honestly, weirdest thing I've realized at the moment, is that this all feels like it's aligned cr.
austere elm
it kind of does
the main shop is wrapped in a UIBox_dyn_container, this exists directly next to it in the heirarchy
slender latch
Actually, what's the code you have to make the playing card CardArea?
austere elm
function populate_shop_playing_cards()
return CardArea(
G.hand.T.x,
G.hand.T.y+G.ROOM.T.y,
math.min(better_illusion.config.playing_card_max*1.02*G.CARD_W,1.90*G.CARD_W),
1.05*G.CARD_H,
{card_limit = better_illusion.config.playing_card_max, type = 'shop', highlight_limit = 1}
)
end
math.min call is there to create the overlap, but the rest i think is pretty standard
oh wait hold on
never mind... i thought removing the +G.ROOM.T.y might change it but no dice
that's vertical not horizontal anyways
slender latch
Odd, threw the code into another place and replaced the object with just a square, works fine, so maybe specifically with the shop.
Try replacing the first .R with a .C?
austere elm
i also just validated that setting the outermost row to cm yeets the box out halfway off the screen
sure, i'll try
ah, i remember why i set it to .R now
lol
austere elm
yeah, still about the same
slender latch
Move it back to R, and the one below into .C.
marsh wadi
Did y'all scope the seal chance?
austere elm
back to the weirdness we're used to
austere elm
Did y'all scope the seal chance?
focused on setting this up right now, you might get better luck in the general mod chat
tried changing all but the outermost to .C just to see, same results
slender latch
Try putting the object inside a new empty row.
slender latch
UI definitely can feel like that, yeah.
austere elm
i think i may have to call it here for the night, thanks for your help!
i wanna figure this out but it's getting late
slender latch
Completely fair.
austere elm
probably not gonna be able to do much with this tomorrow... hopefully soon, though
slender latch
Did y'all scope the seal chance?
Think it's 20% if I'm reading it right?
Yeah, it's 20%, with all seals having equal chances.
marsh wadi
Magic Trick
Illusion
slender latch
probably not gonna be able to do much with this tomorrow... hopefully soon, thou...
If you wanna post the WIP mod here in full or upload it as a dev branch on github, I might be able to find some time tomorrow to experiment with the UI some more.
austere elm
i should definitely commit it, i'll go ahead and do that
slender latch
Magic Trick
- Playing card slot in shop
- 40% chance of enhancement
- 10% chanc...
Honestly, think the Illusion could have a 30/40% on the seals.
austere elm
if anything obvious pops out let me know, i may be able to sneak in some work on it tomorrow after work hours
marsh wadi
Honestly, think the Illusion could have a 30/40% on the seals.
40% is like almost every-other card having a seal
slender latch
40% is like almost every-other card having a seal
Yeah, kind of. I think 30% would be the better option of the two, but, keep in mind it's competing with all the other Tier 2 vouchers. After how the vanilla voucher is almost a detriment unless you specifically have a build that likes it for some reason, it might be better to start overpowered, and then tune it down from there.
solid zinc
I might be able to fiddle with the ui later today too
timber hamlet
<@454101940289142794> i think it was you that suggesting adding them in the main...
Why is there space between the Jokers and the cards?
Also, I think if you want more space, you could make the Next Round and Reroll buttons smaller
The Next Round button is constant size while the Reroll Button might need to be wide. Though I think that’s rare enough it shouldn’t be an issue. Even if it is, they could be placed above or below the other CardAreas rather than to the side.
timber hamlet
back to the weirdness we're used to
I don’t like this because it’s both separate from the main shop but also taking screen space other mods could use. I think Betmma’s abilities hang around somewhere over there. Also Tags.
austere elm
Why is there space between the Jokers and the cards?
it was much easier to make a separate cardarea, code wise, which just did that
austere elm
I don’t like this because it’s both separate from the main shop but also taking ...
luckily i'll be trying to add an option to have the shelf or not
marsh wadi
We love compat settings
austere elm
The Next Round button is constant size while the Reroll Button might need to be ...
also, this is something that i'll look into!
austere elm
Magic Trick
- Playing card slot in shop
- 40% chance of enhancement
- 10% chanc...
i need to check, but i think that the odds you get from vanilla illusion are also affected by hone and glow up
so that's another element to consider
marsh wadi
Probably
slender latch
also, this is something that i'll look into!
I think it's a good secondary option, for when the shelf is toggled off. I do suggest keeping them separate, and maybe addiing another outline or something to signify that it's a difference space from the jokers for specifically playing cards. Kind of like the demo's sneak peek.
austere elm
i don't think i remember that, do you have an example?
if not i can try to reset a profile and play through the demo later
slender latch
Copy pasted from google.
marsh wadi
I think the over/under looks better but there's definitely room to shrink em down
twilit ivy
Overstock Plus also wasn’t a thing in the demo
marsh wadi
counterpoint, Overstock+ making the shop physically feel overstocked is a funny detail
marsh wadi
for drawing over
actually wait lemme just buy out the shop
you can shrink down the shop pretty snug
if you go hyper-compact you get a LOTTA space
austere elm
that looks like about enough space for one more card, two would still need to overlap
but doable i think
i also found a second to do some testing of the default behavior of illusion card pricing
marsh wadi
Overstock+ would also still leave enough space for shop cards to be legible
austere elm
looks like base is $1 and if i'm correct enhancements add no extra cost, foil adds $2 and holo adds $3
i may tweak that
marsh wadi
what about Poly?
austere elm
still checking, i gotta either roll a poly or patch the odds
marsh wadi
k
austere elm
oh nvm the debug tool has a cycle edition tool
poly adds $5
those seem pretty good for edition costs, i may make enhancements increase cost
gonna see if seals affect costs by applying my patch
slender latch
those seem pretty good for edition costs, i may make enhancements increase cost
Something like, +$2 dollars for enhancements that come from tarots which let you select 2 cards, and +$4 for enhancements from tarots that only allow 1?
austere elm
definitely a higher cost for the more expensive tarots like glass
okay, base game doesn't have code to set cost based on seals confirmed
i'm not sure wild cards merit being as expensive as glass though
slender latch
Lovers got upgraded to 2, right?
slender latch
No, think it might've been a mod I saw. Don't often take lovers.
austere elm
same
marsh wadi
Lovers is still one wild
slender latch
I think Lovers and Magician could both be an in-between.
marsh wadi
Luckies did get upgraded to 2
slender latch
How dare you make a minor spelling error. So incredibly rude. It's not like my own messages are edited 50% of the time to fix mistakes.
marsh wadi
I would only do $1 more for enhancements and $2 more for the limited ones barring Wild
and maybe stone?
+$1: Lucky, Mult, Bonus, Wild, Stone
+$2: Steel, Gold, Glass
slender latch
Steel, Gold, and Glass are very powerful, and they don't even have to fit into your build to pick them up, I'd say at least +$3.
austere elm
glass: +$3
steel: +$3
gold: +$3
lucky: +$2
stone: +$1
wild: +$1
mult: +$1
bonus: +$1
marsh wadi
fair enough
austere elm
as for seals, i may just add a flat bonus if a seal is applied
marsh wadi
gonna end up with like $9 playing cards god damn
don't forget players already gotta spend $10 to get this voucher in the first place
slender latch
glass: +$3
steel: +$3
gold: +$3
lucky: +$2
stone: +$1
wild: +$1
mult: +$1
bonus:...
Seems like a good spread to me. I'd say stone would be more expensive if it wasn't behind getting the Magic Trick voucher.
marsh wadi
example sideboard btw
austere elm
i could just make my job easier and say seals are free :P
marsh wadi
so this is a shop with Illusion and Overstock if you wanna bleed the sideboard
slender latch
i could just make my job easier and say seals are free :P
Seals only with Illusion?
marsh wadi
Seals are mostly good earlygame
's why I think they should be a low chance of appearing with magic hat baseline
slender latch
Fair judgement.
austere elm
ugh, this voucher is so hard to balance...
marsh wadi
ok what if
Mults, Bonus, Wild, Stone, no price increase
if you roll those enhancements you just got lucky, bang on
free lil extra
austere elm
i think that makes sense, especially since i'm planning on allowing magic trick to add enhancements
slender latch
ugh, this voucher is so hard to balance...
I think a lot of stuff gets complicated when you want to aim for the quality of vanilla rather than just modded quality.
austere elm
Steel Gold Lucky and Glass, +$1
might still make those +2
austere elm
I think a lot of stuff gets complicated when you want to aim for the quality of ...
fair, i've given myself a high bar to clear haha
marsh wadi
and then are you locked in on gating Editions behind Illusion?
austere elm
none of this is locked in yet
austere elm
if it ends up being too hard i may give up on balancing it well with the base game, but i very much want to
slender latch
none of this is locked in yet
Also, double checking, do editions add a base cost to playing cards or a multiplier?
marsh wadi
surely it's a base cost right?
austere elm
i'll check the code
slender latch
I'm pretty sure they do multipliers for the Jokers, which is why I'm double checking.
marsh wadi
full-compact leaves a lil to be desired
so unless you add a sideboard, you'd have to go extra compact
austere elm
I'm pretty sure they do multipliers for the Jokers, which is why I'm double chec...
the card set_cost method adds self.extra_cost, though i'm struggling to find where the extra cost is defined for each edition
but it is a flat add it seems
austere elm
full-compact leaves a lil to be desired
that's what i feared :/
marsh wadi
it's like REAL close tho
slender latch
Wonder how complex it'd be to add a button.
marsh wadi
like a drawer?
slender latch
A button that opens a menu would be pretty easy, but a button that adjusts just the shop layout to rollout a drawer, I think would be rather complex.
marsh wadi
a drawer would look so shnice though...
austere elm
eh, i think having everything you can buy displaying without extra interaction is the best
i'll make things work within that constraint
whether it means making the cards get really compact or not
slender latch
Yeah.
austere elm
okay, i think the reason i couldn't find the extra cost is because steamodded has extended the game to allow for more
unzipped the base game and searched in there and the concrete values are +2 foil, +3 holo, +5 polychrome, +5 negative
and we're not making negative playing cards so
marsh wadi
if you squish the Next Round/Reroll buttons real tight there's plenty of space
and admittedly, square buttons doesn't look all that bad
solid zinc
I think I can make a drawer
austere elm
if you squish the Next Round/Reroll buttons real tight there's plenty of space
that's gonna be a problem if you have more than $100 though
austere elm
I think I can make a drawer
i would love to see it, if you think it's doable
slender latch
Actually, I think the drawer idea might work if it's out by default, and the button is only there to bring it in so that it doesn't overlap with other mods/take up space.
austere elm
maybe you'll also have some idea what's going on with the alignment of the cardarea lol
austere elm
Actually, I think the drawer idea might work if it's out by default, and the but...
i don't think it'll need a button - if there's a conflicting mod, i plan on having a config option that just brings it into the main shop area and squishes the cards if needed
solid zinc
It should be possible to have a button too
austere elm
er sorry
marsh wadi
you mean if the reroll costs more than a hundred?
marsh wadi
yeah not without like
crazyass mod shenanigans
at which point it is the user's fault, not yours
solid zinc
back to the weirdness we're used to
It’d be like this but with an arrow on the right to slide it under the main window
marsh wadi
honestly why did LocalThunk make SO MUCH space for the vouchers anyway?
why is the Voucher space so damn huge
austere elm
i did want to make the drawer slide at some point anyways, just because it would look nice
austere elm
why is the Voucher space so damn huge
voucher tag lets it hold 2
slender latch
There's the Voucher tag and Double Tag into Voucher Tag.
austere elm
or more with double tags
marsh wadi
sure but it's like
that's still too much space for even 2 vouchers
and like yeah if you got 4 it'd be a bit cramped but what are the odds y'know?
solid zinc
I don’t understand why it’s labelled either
austere elm
and like yeah if you got 4 it'd be a bit cramped but what are the odds y'know?
anaglyph deck would like to talk to you
solid zinc
Or why it’s labelled with vertical text, does anything else use vertical text like that?
marsh wadi
literally nothing else
slender latch
I don’t understand why it’s labelled either
Probably just to section of the space so that it doesn't just feel like a mostly empty space.
marsh wadi
it's the only vertical text that isn't on a joker's art
slender latch
To be fair, the Voucher space also matches the Booster space.
marsh wadi
I was about to say "yknow why isn't there a tag for more shop boosters" before realizing that those tags just instantly give you the booster
austere elm
i think it's also to make clear that the voucher is only for the ante?
since nothing else you can buy from the shop works like that
solid zinc
That’s true
austere elm
lol, this may end up with me making a pull request to smods to add an extra_cost to SMODS.Enhancement
otherwise i'll just code in the base game enhancements
alright i think my time to look at this has ended for now, i'll be back later
solid zinc
I think patching it here is enough
There’s no other reason for enhancements to have a cost
marsh wadi
on playing cards specifically
austere elm
There’s no other reason for enhancements to have a cost
would be so that modded enhancements can affect the cost of cards, even if you don't have this mod
solid zinc
I’d probably just set a default cost of $2 on an enhanced card
Are enhanced playing cards in base game costing $1?
austere elm
yep
base game, enhancements add no cost
even stuff like glass
it's only editions that add extra
austere elm
the way smods patches card.lua to support modded editions is to iterate over the global edition pool and get extra_cost from it
i imagine enhancements would be the same
idk though, i think to start out i'm just gonna focus on base game
slender latch
I think if you take owneship of the vanilla enhancements to give a base cost, you could use that, and then mods, if they want compatibility with your mod, could add a base cost of their own into their enhancements.
solid zinc
Yeah I know how editions work I wrote it 🤣
solid zinc
I think if you take owneship of the vanilla enhancements to give a base cost, yo...
I think this is a better idea then it doesn’t modify base game behaviour without this mod
austere elm
I think if you take owneship of the vanilla enhancements to give a base cost, yo...
i can agree with that
austere elm
Yeah I know how editions work I wrote it 🤣
also nice!
austere elm
pushed code to set extra cost based on enhancement and seal, but i couldn't figure out how to take ownership of the seals
i think i'm missing something about the key that needs to be provided
that said, the enhancement code works perfectly
austere elm
and having thought about the ideas a bit, i think my decision for how this will work is:
and i'll try to make the probabilities scale with hone and glow up
subject to change after playtesting of course but i'm gonna design for that first
slender latch
I guess until SMODS gets an update to allow taking ownership of seals, seals are completely free.
austere elm
i can easily set a default value of 1 and come back to it later
slender latch
That'd make even more sense.
solid zinc
You could directly modify the center too afaik
timber hamlet
You could add a new variable to the type, I think, no?
austere elm
i could possibly do one of those two, would just need to figure out how
away from the computer for now so i may not be able to look at it for a bit
timber hamlet
You can probably hook some function that initialized the type or just a function that creates an object of the type
Alternatively you create a function that tries to access a variable of the type, and if it doesn’t exist, it returns a default value
(So you don’t even need to actually change the type)
austere elm
bah, having trouble getting the shop to show the area right after redeeming magic trick
i'm not sure how to force the ui tree to re-evaluate
is the easiest way going to be just making the area transparent or something?
slender latch
Have you tried :recalculate()?
austere elm
i have, didn't seem to do anything
hold on i'll push up the commit with it so you can take a look
i may be missing something
hooked it into the event that already gets called after magic trick or illusion is redeemed
slender latch
Bit of progress.
Yeah, closest I'm getting is completely rewriting the shop by basically directly copying Game:update_shop() with a few changes, like making G.shop = UIBox rather than `G.shop = G.shop or UIBox``, but, would not work in the end, especially because it'd also completely overwrite the stuff already in the shop.
austere elm
damn :( thanks for trying, i'm not sure what to do about this if that's the case
i'll think about it
probably done messing with this today though, busy evening
slender latch
Yeah, don't think it's impossible, could maybe store the data that's in the shop in some temporary tables, and reload it instead of the normal shop functions, for example, but, unsure still.
Extra thought, if you go with the sliding in/out drawer idea, you could either have it completely hidden underneath the UI like the sliding drawer would need to be, or maybe have it present, but an inactive button or something. Or, yeah, you could just have it clear, and readjust it later.
austere elm
yeah true, maybe this is something i should revisit once i get some help from Eremel
tomorrow i'll focus on tweaking the odds and effects of each voucher, and their descriptions
austere elm
alright, i've pushed up a lot of changes that i'm pretty happy with. here's the current appearance with and without shelf (added a config option)
unfortunately, i'm still completely stumped on updating the shop after redeeming magic trick
right now if you redeem it the card just kinda pops into existence in a random spot on the screen and won't go away until going to the main menu and resuming
if you end up having the time and it's not too much trouble, i'm hoping you may be able to help @solid zinc
austere elm
figuring out replacing the voucher descriptions, but i'm not sure i'll be able to make this bit conditional to the rework being enabled or not
at least not while being able to format the text
it seems that interpolating text with {C:attention} or similar using loc_vars doesn't actually evaluate the format code
it just adds the text literally
slender latch
Add it into loc_txt instead of loc_vars.
austere elm
but then i can't make it conditional, right?
slender latch
Oh, if you want to make the color conditional, use {V:1} in the loc_txt, it takes a color from colours = {} in loc_vars.
austere elm
i don't want to make the color conditional, i want to add text onto the end of the voucher description conditionally that happens to contain formatting
(specifically , may have an {C:enhanced}Enhancement{})
slender latch
I think you'll have to work around it, meaning you'd have #1# {C:enhanced}#2#{}.
slender latch
No worries, hope it works out correctly.
There is another way to do it I think, maybe through localization? I don't know enough to explain how it works, but, you could look through the Lobotomy Corp mod to figure out how it does variable text.
austere elm
that would make sense, i was trying to mess with the localize function a bit but wasn't finding anything
i'll definitely take a look through there if i don't get this in a bit
slender latch
Looked through Lob Corp to remind myself - It uses a generate_ui function to set desc_key for the text. If you wanna look through it yourself, look inside the individual jokers and the localization folder.
austere elm
think that's done it!
it would've taken me a while to find out about that, thanks again
slender latch
Maybe add "from a new area in the shop"?
If I saw it and thought it was just adding enhancements to the base voucher, I'd probably still be reluctant to pick it up.
austere elm
yeah, fair point
fixed!
i think that's everything done except for the work on reloading the shop and making the drawer look better
marsh wadi
I'd reword this to "may have Editions and Seals"
austere elm
i copied that language from the base game and i think it makes sense, since you can only have one edition or seal at a time
marsh wadi
fair enough
austere elm
just noticed an interesting consequence of taking ownership of the enhancements to add extra cost
now every enhanced card has this mod's badge on it
marsh wadi
oh hey an idea for the difference between Illusion and Magic Trick
you could make it so Magic Trick can have enhanced cards but the enhancements you can get are only Bonus Mult and Wild
then Illusion adds all other enhancements to the pool
Idk where stone would fit in
austere elm
maybe, i'm not sure
i really want to get the ui fixed before i mess around with balance, right now i haven't been able to do a lot of playtesting because of the interface being broken
slender latch
Had a thought, maybe look at how the sell/use buttons attach to cards, and attempt something with that? I haven't figured out the details of it yet, though, might not work at all, especially if it requires the card to be interacted with first.
austere elm
i can take a look at that part of the code, it probably won't be until tomorrow or sunday though
busy busy 
austere elm
the name isnt there
fixed, ty for pointing it out
austere elm
looks like this mod crashes the "Bram Poker" challenge, i'll have to look into why
should be fixed now
weak falcon
does this mod still work on modern versions? had an idea to make a mod that was basically just exactly this mod, then found that it already exists
wanna make sure if it still works fine
okay it seems to mostly work correctly, only issue is when you first obtain the voucher it puts the card slot off in the left corner instead of expanding the shop
(this is on the beta branch with the option that turns it into an actually good voucher)