NotJustYet - overscoring antidote

[fickle rain]

i don't like the gameplay style surrounding "avoiding overscoring" in order to scale jokers/greed more, so i made a janky mod to change that (it's more of a proof of concept, i suppose)
this might already exist, but i searched a bit and couldn't find anything similar

*note that while this is intended to be "quality of life", this is an objective advantage in all situations, and can heavily imbalance certain aspects of the game, much more than i originally expected it to.

**also the End Round button is ugly as all hell, but i hate messing with UI... and i'm lazy

(Steamodded 1.0)

https://github.com/Toneblock/balatro-NotJustYet/releases/latest

[dawn marsh]

Nice, will try

[fickle rain]

already a crash, nice

sorry lol

[dawn marsh]

Crashed when...played a hand?

[fickle rain]

curious why that's happening

[dawn marsh]

Prob bcuz I have a ginormous mod list

Lol

[fickle rain]

hmm

seems to be breaking with smod's palettes?

or perhaps the palette mod

send your version of smod if you want, it's possible it just may not work on outdated versions

[dawn marsh]

I'm on the latest

[fickle rain]

i'll create a version without any colour changes... as it seems to be what's crashing on your end

alright, you can try this for the time being, it's the same thing without the dynamic red/green colour for chip totals

if anybody else reports a crash from the colours, i'll make this the main version lol

[dawn marsh]

I tested it on a new test instance with no other mods, works fine

In my nightmare pack, not so much

[fickle rain]

ah

i'm stupid

[dawn marsh]

Oh I should've pointed out it's the red-green light version

[fickle rain]

yeah don't worry i got it

it's talisman, not the colours at all

[dawn marsh]

Glad I am helping

[fickle rain]

yeah tysm actually, this would be incredibly common

[dawn marsh]

No I put this non-colored version with other mods

[fickle rain]

yeah it changes nothing

[dawn marsh]

And colored version I tested on its own

[fickle rain]

the non-coloured version was not helping with the crash

[dawn marsh]

But isn't them causing different crashes?

Wait no they are same nvm

I'm just blind

[fickle rain]

they miight be different actually

this should work with nightmare modpack?

[dawn marsh]

Will try

[fickle rain]

oh no

no it won't

talisman overwrites a lot of stuff i'm using

[dawn marsh]

That's sad

Maybe I'll test without talisman

[fickle rain]

i've created a fix but it requires a change on talisman's end

[safe stump]

tested it with 1.0.0-alpha-0617b steamodded and didn't find bugs

[fickle rain]

yeah, it should work with vanilla smod fine

ty for testing 👍

[safe stump]

mods

[dawn marsh]

Uh oh

[dawn marsh]

It just casually cash-outed

Lol

[fickle rain]

like the mod doesn't work?

yeah i know why

[dawn marsh]

It's nightmare pack but don't have talisman

[fickle rain]

oh what

[dawn marsh]

Yeah 😭

Sorry but I don't have time to test out mod conflicts, it will need to be postponed

[fickle rain]

tysm for your current help on this

i'll get to fixing the several mod conflicts 👍

[dawn marsh]

Do you need the list of mods that I am using?

[fickle rain]

you can send it if you want i suppose

[dawn marsh]

They are all up-to-date

[fickle rain]

ty 🙏

didn't have to do that

[dawn marsh]

Take it easy

[bright agate]

Interesting question: If I have over the required score and use up all my hands, will i just lose?

[fickle rain]

nope, same if you run out of cards in deck

it'll automatically end the round, and whether you win or lose depends on your score

[fickle rain]

found the conflict, it's the lobotomy corporation mod

thankfully they have a higher priority on their lovely.toml so i can patch the patch without problems

[fickle rain]

mod compat all up and running :)

https://github.com/Toneblock/balatro-NotJustYet/releases/latest

[dawn marsh]

Thank you, now I will try this with talisman too

I did try with talisman and crashed

New crash

[hearty lion]

i'd test it with just talisman and lc tbh

[dawn marsh]

I tested with only talisman and not just yet, works good

[hearty lion]

hey, you should probably add a check for if Talisman.config_file.break_infinity is true

it crashes if you don't have it enabled

[plain moth]

finna try it out. is there any fatal compat problem with other mods unsolved yet?

[dawn marsh]

Maybe there's something still unsolved. I'm still getting crash when talisman and other mods present

[dawn marsh]

Removed mythblind and mathblind and the crash goes away.

[fickle rain]

oh tysm

i'm being incredibly silly

[fickle rain]

no idea what the blinds are doing

now i'm even more confused because those blind mods shouldn't affect anything... and on my end, they don't?

[dawn marsh]

When I went in to new ante, it crashed. Since I have to remove both of them to work, maybe it's their own cause and not related to this mod

If nothing can be identified I will actually just ditch both blind mods lol

[fickle rain]

i can't seem to replicate it?

it's possible they might be conflicting with a random, more related mod

because i don't see anything in the code that would clash with what they're doing

[dawn marsh]

Ok then I'll just skip them

[fickle rain]

again, both mods do work with this mod on their own

[dawn marsh]

I'll try if I can find the log for that time

[fickle rain]

either it's a complex web of conflicts or it's something out of my control lol

[fickle rain]

i think this crash is pointing to the get_new_boss() function

[dawn marsh]

You are totally right

[dawn marsh]

Maybe something is conflicting with that function

[fickle rain]

traceback is pointing at a couple things

oh

[dawn marsh]

Bunco?

[fickle rain]

no

mystblinds solo crash, not even a conflict it seems (actually no)

[dawn marsh]

But I tried removing myst and leave math it still crashed

[fickle rain]

yeah it doesn't make sense

[dawn marsh]

I will really just leave them behind, it's not your problem

Like at all

Blinds are conflicting between each other maybe it's just that

[fickle rain]

nah this just makes no sense

idk why it's breaking lol

[dawn marsh]

Or I have a better idea, report to their channels

Lol

[fickle rain]

could be anything from an smod issue to an issue with a particular blind mod

[dawn marsh]

I'll report to the channels

[fickle rain]

the only thing that makes me even more annoyed is that i can't replicate it

lol

[dawn marsh]

Yes that why I am annoyed too

[fickle rain]

welp

hopefully it's fine for now, i'll just leave it be

[thorn juniper]

since you have so many other mods installed I'd advise downgrading to an older SMODS version, as the newest one has some breaking changes (to blinds, mainly) and therefore one of the other mods might cause crashes due to that (aka, this mod probably works perfectly fine with the newest version of SMODS)

[dawn marsh]

Ah I see, the blinds mod all need newest smods iirc

It really is a nightmare for me

[thorn juniper]

the blinds mods all need fixing for the newest SMODS

because its quite new

and I doubt all mods have been updated yet

[dawn marsh]

I thought they all pushed new versions aren't they

[thorn juniper]

I doubt they all did so quickly

[dawn marsh]

Maybe still need some tweaks

[hearty lion]

yeah, this many mods could break stuff a lot

[plain moth]

for the new blind stuff, let alone the fact that many of em have already pushed fix for that its literally simple to fix it yourself. you just need to remove blind from the parameters then change all blind.xxxs to G.GAME.blind.xxx thats it

[thorn juniper]

bold of you to assume that people who use mods are able to "write" code

[plain moth]

i dont think its hard if you really want to get into the game without rolling everything back

or lets just say if ur always eager to trying bleeding edge stuff the chance of you having zero idea how to fix it/how to get to know how to fix it, is simply low to the ground

if you choose to try alpha stuff you choose to learn something new

[thorn juniper]

some people see exactly this when they look at code

https://tenor.com/view/hachikuji-monogatari-minecraft-mayoi-hachikuji-enchantment-table-gif-27334415

[dawn marsh]

I tried some more mods. Don't work with codex arcanum, works with DX-taort

[fickle rain]

codex???

it's still 0.9.8 right

weird, it shouldn't have any lovely patches

[dawn marsh]

Uh I altered the lua file (thanks chromapie for teaching how)

[fickle rain]

does it just crash when loaded with codex

[dawn marsh]

It attempts to keep going after scored enough but just cant

[fickle rain]

huh

so softlock

[dawn marsh]

No it cashed out

[fickle rain]

oh

[fickle rain]

for some reason codex has a redundant check here in CA_override.lua...?

it's not on the github source (which is what i was checking for about 45 minutes...) but it's bundled with the release

oh i assume it's a hackfix for terra purposes actually

if you want, you can just remove this code with no consequences, it's likely not going to exist in the updated version

but idk if i can do much about it

[dawn marsh]

You are already doing extra.

[dawn marsh]

Btw I tested it it works fine now

[dawn marsh]

@fickle rain hello, can I add your mod in my modpack?

[fickle rain]

sure, go ahead

[dawn marsh]

Any chance for the end round button given a keybind/hotkey

[fickle rain]

possible

what would be a convenient spot to put it, if anything

[dawn marsh]

At least shouldn't conflict with existing ones

Mainly smods has some keybinds but I don't have a list for that, maybe aure will know

[fickle rain]

https://github.com/Toneblock/balatro-NotJustYet/releases/latest

i gotcha

if the default really should not be left shift, let me know

[dawn marsh]

Awesome, I'll try out!

[dawn marsh]

I thought it's causing the debug plus log (shift + /) cannot be disabled so I set it to enter, doesn't work. lctrl is fine tho

[fickle rain]

huh

[dawn marsh]

Maybe enter is used somehow

[safe stump]

I found a bug, here's how to replicate this:

1. have 5 gros michel/cavendish
2. win a round with the last hand
3. while the gros michel/cavendish show "Safe!", click on the button.
4. watch how the jokers show the message twice, ante goes up by 2, and then the game crashes

I think a solution might be disabling the button if the game already is calculating the end of round

[fickle rain]

huh

i updated the mod recently with something that affects last-hand wins, but i'll have a good look once i get home because more stuff could be affected similarly

thanks for reporting

[fickle rain]

fixed... but there seems to be another similar bug lurking that i just can't replicate
ignoring it for now as i can't figure out if fixes are working

https://github.com/Toneblock/balatro-NotJustYet/releases/latest

[dawn marsh]

Somehow round end button is conflicting with discard button even after I changed keybind in mod file

So if you play with controller, default discard is pressing Y

But it will be round end when Not Just Yet is installed

Uh basically it blocked discard and react to Y button

[fickle rain]

wha

[fickle rain]

i mean it makes sense, most mods don't support controller

i'll see what's going on

[dawn marsh]

Doesn't make sense to me tbh

[fickle rain]

i mean

i never checked it

so that's why it exists

makes sense that way 😭

[dawn marsh]

🤪

[fickle rain]

v0.5.0 release, fixed a couple things that were bugging me
i'm still unsure about mod/controller compat (please report those) but overall the mod is a lot better now

https://github.com/Toneblock/balatro-NotJustYet/releases/latest

[dawn marsh]

#1255696773599592458 message

[fickle rain]

incompat somewhere

shame that the only way to make that work properly is to handle something that's very prone to being changed/broken

[fickle rain]

actually i could probably just hook it

[fickle rain]

ok i pushed a fix that should prevent all future instances of this

[stable cipher]

I hate just raw-dogging questions into threads because I'm sure it's been asked before, but Discord searching threads has no support, so apologies if you've answered this already:
It seems that when I hit the button to end the round, my Gold Cards aren't paying out and are just getting discarded instead. Have you seen this behavior before? Is there something about this mod I should be doing differently to trigger them?

Or do I maybe have a weird compatibility interaction happening here?

[fickle rain]

odd

ik lovely 0.7.0 isn't working exactly so

that's the best thing i can think of since this mod doesn't actually mess with the end of round, it just separates it

suffice to say, it's likely this isn't even a mod incompatibility, some other mod is breaking this