dim sluice
SilverSeal - https://github.com/mwithington/SilverSeal
A mod for Baltro that adds in a silver seal which will apply a random edition to the card.
Once the card is played a second time a new edition will be applied.
The edition will only count after you have played the card at least once.
dark forge
Does this stack the editions?
If not seems kind of redundant and just worse than the spectral card that adds editions
dim sluice
@dark forge No it does not! It is meant to be that playing it is a bit more strategic because you might need chips on one occasion or mult in another but it maybe different the next time you play it! A bit of a gamble mechanic! Any thought on improving it? Happy to try!
undone shuttle
great stuff 🙂
echo fossil
Using both silver and green seal mods seems to cause game crashes on boot
Green is by Axbolduc though
undone shuttle
probably has to do with how the way seals are populated, since iirc theres not a way of neatly injecting into the game with steamodded in a way that makes it other mod friendly
dim sierra
I use both and am not crashing
echo fossil
hmmmm
dim sluice
Sorry guys Ill take a look and work with Axbolduc on this!
loud galleon
pretty sure its just having 2 of the seal adding thing breaking the game
kindred thunder
So I posted this in Green Seal and only just realized that it's actually two different authors and not two mods made by the same person. The implementation internally was so similar that I just assumed it was the same creator. You seem to be a bit more active so maybe you can help me out instead:
So I was diagnosing some compatibility issues between some mods in my list and I believe that I've narrowed it down to Green/Silver Seal.
I have another mod, MystJokers, that has a Joker that manipulates how many picks out of the card pack you are allowed to have, but it seems to hook into Card.open as part of that functionality. I noticed that your comments basically suggest that you've re-implemented Card.open from scratch to insert your own logic and that it might break things that try to touch the base functionality.
Is there any chance you could talk through a suggestion of how I can get other mods to reference your implementation instead so I can hopefully get these mods to all play along?
dim sluice
Yeah @kindred thunder I would be happy to take a look! The new function that is in the SilverSeal code is based on @lean oyster’s method. The original method is not super extensible so this is a solution that made adding more seals into the pack. What could be done is pulling this section out into a util method. Ill see what I can manage! Ill try to implement my mod with MystJokers
kindred thunder
Yeah, if you're willing to do that kind of effort, then I'd really appreciate it. I can manually back-edit my copy of Green Seal to get compatibility on my end if I have your methods to reference. I really appreciate you taking the time to take a look.
dim sluice
Yeah, if you're willing to do that kind of effort, then I'd really appreciate it...
Sorry I have not replied I will have some time to look at this later in the week just want to make sure that I am not ignoring you!
brazen topaz
@dim sluice hi, is it possible to make it more silver than gray please ? 😶🌫️
I did it on my own but for future users
dim sluice
<@184876391647412225> hi, is it possible to make it more silver than gray please...
Yes if you want me to! Do you have the asset i can do that today!
brazen topaz
But taking the gold one should be better as it has reflection on it
dim sluice
I think that is a shader @brazen topaz that would be adding some code and having people mod the source code I think… could be wrong though
brazen topaz
No problem
brazen topaz
Could be great to have the seal deleted after use ? 🤔 Instead of having it always triggered ?
dim sluice
Could be great to have the seal deleted after use ? 🤔 Instead of having it alwa...
https://github.com/mwithington/SilverSeal/releases/tag/v0.0.3 Here is the updated picture! I did have to make my own only due to the fact that it needed to be a empty background! hope this works sorry its late!
brazen topaz
No problem at all 🫡
brazen topaz
I made a little PR https://github.com/mwithington/SilverSeal/pull/1 😶🌫️
slate basin
Hello @dim sluice , I'd like to bundle your mod in a modpack. To ensure that I can update the version of your mod easily and without copying your code directly in my repository, I'd like to use a git submodule. Like that, it would just be a link to your repo. Would you mind if I add your mod in my modpack ?
dim sluice
Hello <@184876391647412225> , I'd like to bundle your mod in a modpack. To ensur...
That is awesome! Yeah go right ahead! Just tag me somewhere if that is easy also send the mod pack here when you are done!
slate basin
thanks ! I'll post the modpack when I have agreements from the mod's owner that will be featured in the modpack
upper marsh
Quick heads up, support for seals is coming to Steamodded in the next release. I'd love to hear from you if there's anything that we've missed or that you want to see added to the seals API in order for you mod to use it while being compatible with other seal mods. The code is up on the Steamodded github page already and will be deployed as a new release soon.
dim sluice
Quick heads up, support for seals is coming to Steamodded in the next release. I...
This is great! Im going to take a look tonight and Ill get back to you on what I think!
upper marsh
Thanks!
dim sluice
Thanks!
Do you plan on putting an example mod in for seals at some point? I'd be happy to contribute!
upper marsh
Do you plan on putting an example mod in for seals at some point? I'd be happy t...
that'd be great, feel free to file a PR for one
dim sluice
that'd be great, feel free to file a PR for one
Hey so currently the seal API within steammodded will add the seal to the game as an entity but it will not be actually obtainable within a run. Currently the open pack code is not designed to handle an extensible amount of seals. you can see how @lean oyster and I put in our mods the overwritten card.open function to allow for this. Do you want me to open a PR for this? Please see: https://github.com/mwithington/SilverSeal/blob/caf773d6c238e0637788cb9b4a7707368ae2bc3b/SilverSeal.lua#L90 on why this was needed.
upper marsh
Hey so currently the seal API within steammodded will add the seal to the game a...
Sure, go ahead and open a PR for it. The seal API isn't my code originally and I haven't digged too deep into how it works. I'm almost done deploying the release for 0.9.2, so we won't be able to fit it in there anymore, but we'll have it on the radar for the next release after that
dim sluice
Sure, go ahead and open a PR for it. The seal API isn't my code originally and I...
Alright will do this weekend when I have time!
dim sluice
@upper marsh https://github.com/Steamopollys/Steamodded/pull/58 this is something I just did as quickly as I could so you could see what I mean lmk if I can make it better!
dim sluice
@upper marsh did you get a chance to look at the PR?
upper marsh
<@538635176847343636> did you get a chance to look at the PR?
I've looked at it briefly, and I think there's a better way to do it. Pretty much I'm waiting on a new release of lovely to be able to do so
dim sluice
I've looked at it briefly, and I think there's a better way to do it. Pretty muc...
I would be intrigued to know your thoughts thanks for looking at it!
upper marsh
basically I don't like to destructively overwrite so much code I have no concern with. It's possible with lovely to just patch something in in place of the relevant if/else if blocks, but there's no unique line for me to base the patch on, so we need to wait for support for it first
gleaming minnow
basically I don't like to destructively overwrite so much code I have no concern...
ETA 1-2 days
work takes priority atm 
gleaming minnow
and thank you for yours :3
