Whammy effects cause guitar stem to play late in current nightly.

[rare parrot]

I had had them turned off for a while. Turned them on last night, and the next time I played a song with actual guitar stems, realized the guitar audio was noticeably delayed from where it ought to be - not by a tremendous amount, but enough to sound and feel wrong.
Disabling the whammy effects seemed to alleviate the issue.

For the record, my settings included A/V calibration at zeroes (albeit with hardware latency compensation enabled) and audio buffer disabled. Neither turning-off the compensation nor enabling the buffer seemed to change things, however.

[faint stump]

This was an issue on stable that should have been fixed on nightly.

Is it much worse on stable? Was this when playing the song or when previewing?

I'm wondering if either:

1. The offset adjustment isn't taking effect at all
   or
2. The offset adjustment is wrong

[rare parrot]

I haven't checked stable; I'll look into that.

I first noticed the issue in gameplay (playing a chart which seems to have used artificially-separated stems, so some but not all of the guitar sounds were being delayed), but afterwards I realized I could hear it in the preview as well. It was via the preview that I confirmed the issue remained when turning off latency compensation and turning on the buffer, but went away when turning off whammy effects.

[faint stump]

One thing you can try, if you have an unpacked song, replace all stems with the same metronome track. Then it's easy to hear if the stems are synced

[faint stump]

@rare parrot so I did find one issue with whammy

There's two parts to syncing up whammy, initial offset and sync drift

The initial offset is working correctly I think, but the sync drift was not fixed correctly, I'm gonna push a fix soon.

In the meantime, here's a metronome song if you want to test syncing yourself, right now you should hear it start in sync and then slowly drift

[faint stump]

fixed now, thank you for your excellent hearing

[rare parrot]

Today's nightly is supposed to include your fix, right?
I'm still hearing the difference with the same song I was hearing it on before. Starting to wonder if maybe there's something funky about this particular con file?

[faint stump]

Should be fixed yeah

If you want you can dm me

Also, do you have audio buffer enabled or no?

[rare parrot]

I believe I have audio buffer off currently

interestingly, I've just tried converting this con file into a traditional ini/mid/ogg set, and the offset is gone in the converted version. maybe there's some subtle difference of how moggs are being handled?

confirmed, I have Use Audio Playback Buffer disabled.

[faint stump]

Thanks for checking

I wonder if there is a stem that has active pitch shift but isn't getting reset, idk how that would happen though