Credit Card Components suddenly allow whitespace cardholder | Mollie Community | Page 1

marble heron Feb 22, 2023, 8:03 AM

#

hi
my cypress tests figured out that a simple whitespace as cardholder name doesnt lead to an error anymore in the components? is this on purpose, should i change my test or is this a bug?

mental summit Feb 22, 2023, 9:23 AM

#

@west parcel

marble heron Feb 22, 2023, 3:38 PM

#

The constraints on components was changed recently, so this might be a sideeffect of this.

marble heron Feb 24, 2023, 8:39 AM

#

ok thanks , will it come back? should i activate the test again or is it gone now?

west parcel Feb 24, 2023, 12:58 PM

#

Hi Christian
We have indeed released some enhancements to the CC components field in order to optimise cards performance. A simple whitespace or a series of numbers only are no longer allowed.

marble heron Feb 24, 2023, 3:57 PM

#

thats funny @west parcel
because my cypress test was originally testing that whitespaces are NOT allowed
now it IS allowed. i manually checked it. if i just leave the card holder name, it works

west parcel Feb 27, 2023, 1:50 PM

#

Oh interesting find. Let me get back to you on this. Looking into it now/

#

@marble heron i am currently testing it and i get an FE validation error with whitespace. Are you entering whitespaces or leaving the field blank altogether?

marble heron Feb 28, 2023, 7:21 AM

#

hi, its a whitespace
you can see it in line 110, and the previous expected error in 120
https://github.com/mollie/Shopware6/blob/master/tests/Cypress/cypress/e2e/storefront/payment-methods/creditcard.cy.js

GitHub

Shopware6/creditcard.cy.js at master · mollie/Shopware6

Contribute to mollie/Shopware6 development by creating an account on GitHub.

#

that test failed, and when i tested it manually i was able to reach the mollie payment page

west parcel Feb 28, 2023, 8:21 AM

#

Ah i see. Ok so what we did was to add additional Front-end validation in components so that a user does not go all the way to submitting their card details only to be told from the backend that their details are not valid (in this case that the Cardholder cannot be empty). So now the check happens in the frontend as well. So i think the test should now assert on Components error. assertComponentErrors(false, true, true, true); (i think although i am no proficient with Cypress.

marble heron Feb 28, 2023, 9:50 AM

#

but the problem is that an empty cardholder name with whitespace is valid from your JS compnents and brought me to the payment page

#

that is the actual problem,

#

let me just run it again and see if its still happening

west parcel Feb 28, 2023, 9:54 AM

#

Could you take me through the steps on how you are able to reproduce it manually please? I have tried on multiple orgs in both test and live and I am not ever able to submit a card form with an empty space in the card holder name. Having the repro steps will ensure i am mirroring the same situation as yours.

marble heron Feb 28, 2023, 9:55 AM

#

its working again, so now i get a successful (and different) message
when i wrote this issue, cypress and my manual test showed it was redirected to the mollie payge

#

i also see that theres a min 3 letters now? thats probably what you meant by extending verification...
so seems good now, maybe small hicups (i usually know quite fast if sth has deployed at the mollie side that changes things :D)

west parcel Feb 28, 2023, 9:58 AM

#

My apologies about this. We should have posted this forum indeed. We will make sure to be more diligent in the future. Let me know if you see any other issues with this validations. Thanks!

#Credit Card Components suddenly allow whitespace cardholder