FavouriteAnything

[onyx sinew]

add any image to the favorite gifs tab

https://plugins.nin0.dev/favouriteAnything/

[somber iron]

love

[daring prairie]

false advertising
i cannot, in fact, favourite anything

[tired vapor]

report nino

fake developer

[onyx sinew]

send first image here

[lone fable]

ninoware

[onyx sinew]

this worked like two seconds ago

[daring prairie]

GIF text does appear in the top left for like 2 seconds on some then vanishes

[daring prairie]

it works in this embed

[onyx sinew]

weirdd

[lone fable]

I think this is the condition that is checked when the fav button is rendered, the gif tag is added separately

[onyx sinew]

so should i just patch this regex

to like .+

[lone fable]

no 😭 that's horrible (ik i did that in my snippet)
patch the component maybe

[onyx sinew]

you patched RegExp

this is even worse

oh icic

[lone fable]

like you could just always make it return that jsx
I wonder whether that would break in combination with other image accessories

[onyx sinew]

this hsould work @lone fable

but it doesn't

[lone fable]

hmm

thought i'd check how the bd plugin does it, and it's 12000 lines long

they're rawdogging react dom AND real dom at the same time

[onyx sinew]

https://tenor.com/view/rule80-rule-rules-dragon-ball-z-devilbro-gif-23657697

[daring prairie]

its actually like 4000 lines, most of that is tanslations

[main river]

why?

[onyx sinew]

shitcode

[main river]

guh why the friend invite

[onyx sinew]

accident

[main river]

ok

[elder marlin]

I'm trying to port a DevilBro BD plugin to Vencord and it's actually hell

[lone fable]

If you're rewriting a BD plugin from scratch, don't ever use the original code as reference

[tired vapor]

or you'll end up like this guy #🧊-off-topic-iceman-only message

[tough raptor]

turns out these favorite medias show up on mobile too

[vocal rose]

Hi, i know this is still not working but is there a fix yet?

[lone fable]

@onyx sinew can I do a PR to make this work with videos and attachments and stuff

[onyx sinew]

sure

[lone fable]

rich embeds are kinda weird but the rest should work fine
https://git.nin0.dev/userplugins/favouriteAnything/pulls/1

[tired vapor]

all this because i suggested stealing some dpreviews snippet

bless u both

[lone fable]

[lone fable]

~~Figured out how to make this work with rich embeds, what should be the default behavior?

1. Save the original link (eg vxtwitter.com/...). This is cleaner, but the embed content can change over time. Could lead to abuse.
2. Save the media proxy link (eg images-ext-1.discordapp.net/...). This is kinda messy, but there wont be an embed border and is impossible to abuse due to the unique hash~~

nvm, turns out some providers have custom short links that also point to the raw video file. It's a nice middleground between the two

[lone fable]

nino will try https://git.nin0.dev/userplugins/favouriteAnything/pulls/2

[narrow onyx]

Because of it, my Discord now crashes every time I open any chat in the guild. (i didnt try dm`s, but of friends tab did not crashes)
||at least of equicord||

[lone fable]

Do you see any errors in the console? (ctrl-shift-i, then click on the console tab)

[narrow onyx]

https://i.imgur.com/i00Omi0.png

https://pastebin.com/8MhN1NTh

If disable the plugin, any errors that occur during similar actions disappear.

[lone fable]

uhh nino git seems to be blocked on my network wtf

anyways here's the fix
go to vencord/src/userplugins/favouriteAnything (or wherever your local vencord copy is)
copy the file there
and run git apply fix.patch

I dont even know who the real nin0 is 😭

@onyx sinew

@orchid prism hiii can u commit this patch tyy

[orchid prism]

?remind 6am

[stone dust]

Alright @orchid prism, in 19 hours, 57 minutes and 41 seconds: …

[orchid prism]

?remind 2h

[stone dust]

Alright @orchid prism, in 2 hours: …

[orchid prism]

no ssh just exploded

this doesn't persist restart for some reason

[stone dust]

@orchid prism, <t:1769248951:R>: …

[lone fable]

https://tenor.com/view/cat-explosion-sad-explode-gif-15295996165959499721

[stone dust]

@orchid prism, <t:1769248939:R>: …

[pure swan]

https://tenor.com/view/jesse-wiser-wiser-living-make-it-happen-gif-22847282

Who needs embed perms anyways 😭

[shadow canyon]

is it possible to make also allow you to favorite mp3 / audio files

[lone fable]

I wanna keep this compatible with vanilla discord, so for previews we would have to use a pregenerated image, maybe showing the audio file name and length (which is definitely doable)

however discord doesn't embed external audio files in any way, which is kinda annoying and I dont know if there's a way around this

maybe it could be sent as a voice message, but you no longer have access to the original asset id, so I doubt discord would allow you to send a random file in this way

[orchid prism]

or as an attachment?

do these embed on desktop

[lone fable]

yup this shows up fine on desktop

Maybe we could do a combined approach where with the plugin you're able to reupload the favorited audio files and without it it just sends a link

[orchid prism]

yeah

[lone fable]

discor just broke video favoriting in the new canary build, the patch no longer works

[lone fable]

@orchid prism thoughts on this UI? (demo image)
I realized it would be super easy to extend "favouriting mp3 files" to "favouriting files" (turns out all types of files can have the same sort of decorator button with little that needs to be changed)

however idk whether to send the file when the user clicks on it, or allow for interaction (eg if I want to play an audio file before sending it)

or maybe have a send button on the right?

[orchid prism]

id say more this

[lone fable]

alright

also would you be willing to create and host a very simple placeholder image service, similar to https://placehold.co/600x400?text=file.mp3 ?
I need a thumbnail for these files for the vanilla client which would show basic info like the file name and maybe file size

but the only way I found to manually generate a valid cdn/media.discordapp.com link without a message is to use the unfurl embed endpoint which only works with full website embeds

so the process would be

1. the plugin dynamically generates a link like embed.nin0.dev/?name=file.mp3 (I'll specify the full details later)
2. client sends a request to /unfurler/unfurl with this link
3. the awesome nino backend generates a simple embed with a thumbnail image
4. the thumbnail image gets saved

oh damn placehold doesn't even embed on discord at all

[orchid prism]

interesting

yeah i could do

[lone fable]

yayyy thanks

[shadow canyon]

i also like this version more

[lone fable]

[lone fable]

Small progress update, I've added an option to favourite external videos (you can identify those by the "open in browser" icon)
Ill hopefully have the whole update finished during the next week

[lone fable]

It's finally done :D @orchid prism
I used a random japanese thumbnail service for the time being, so if you notice that favouriting a file takes too long, that's most likely the cause. It'd be cool if you make a custom one tho once you have time

[orchid prism]

oo nice

i've been at home a lot lately (sick) so i might do pretty soon

[lone fable]

lmk if you find any bugs, I've spent so long on the files thing that sometimes I managed to break gifs without even noticing

[lone fable]

TODO:
fix mosaic embed styles
fix long file names

[lone fable]

TODO: Fix not being able to send files in dms

[hollow elm]

favourite star for files aint existing for me

also, why is the fav icon in the top right when the discord default is alr in the top left

[lone fable]

did you update to the latest version of the plugin?

[hollow elm]

why would I be here if not

[lone fable]

They use completely separate components for the gif favourite button and the file accessories, and it was easier to inject into the accessories thingy 😭

[hollow elm]

aaaah gotcha

[lone fable]

hmm, is it just this one file or does this happen with all files?

[hollow elm]

all afaik
dont got that large of a samplesize tho

docx and pdf only actually

[lone fable]

hmm, I've tried it with pdf files and it seemed to work fine on my machine ™
do you use any plugins that could be interfering?

[hollow elm]

lemme investigate then

ive disabled every plugin except yours and themes as well and its still broken

gimme some time to enable them again

[lone fable]

😭

[lone fable]

could you send me one of the files that are broken (if it doesnt contain anything personal)

[lone fable]

Thanks to zero for notifying me, I didn't realize that discord was once again using and old ahh electron version which would make it error when generating a url for the ⭐ button

I've added a polyfill for the missing methods and I'll PR it tomorrow

The plugin should otherwise work fine on vesktop and web

[lone fable]

I wonder if vee would accept this as an official plugin

[orchid prism]

probably

i should get started on the api

[lone fable]

btw i PRd the fixes if u want to check

[scarlet blaze]

does this work? I just installed it and nothing seems to have changed

[vocal rose]

https://cdn.discordapp.com/attachments/1452379684233941127/1468218340387590348/2a27b19ddb2a47c1a4a90cf47a3e78d4tplv-jj85edgx6n-image-medium.png works for me

oh no embed perms

[scarlet blaze]

I must be installing them wrong. I followed the guide but I don't see 3rd party plugins anywhere in the app

new to this

[scarlet blaze]

I got it working. I messed something up

[solar briar]

Plugin never loads. I built and even updated my vencord (equicord actually), even ran it through userplugininstaller in case I did anything wrong

Was met with:
"Error: Error invoking remote method
"VencordPluginNative_Userplugininstaller_initPlugi
ninstall: reply was never sent"

[solar briar]

What was it if I may ask?

I might have the same issue

[lucid vigil]

#1302000818131828810

That error is caused by that plugin

[solar briar]

No I understand

My issue is with this plugin not loading

I simply used nino's other plugin to see if it does load correctly

But it didn't on both sides

[scarlet blaze]

I was followng the last step all wrong. the rebuild vencord

[solar briar]

You used pnpm build right?

I'm running that command in the parent folder (not src)

[scarlet blaze]

at first no I didn't do it at all but when I did it didn't work at first. I ended up doing the whole vencord install process again and it was fine

[solar briar]

Never mind that's probably not my issue then

[scarlet blaze]

run it in the vencord folder

[solar briar]

Pnpm build works for me in other plugins

[solar briar]

What I did

[scarlet blaze]

ah gotcha

yea idk but I did get it working now

gl

[solar briar]

Thanks regardless

[scarlet blaze]

[coarse grove]

is this fixed or smt

[lone fable]

yeah, you should update if you havent already

[lone fable]

TODO:
add support for custom file titles cuz apparently that's a thing now

this gets converted to "Idk_example_title_lol" which looks ugly

[orchid prism]

67

[lone fable]

https://fxtwitter.com/May1936_/status/2029834525824741641.gif

[kind gulch]

you guys should add banners to favorite cause It's technically an image

[lone fable]

wdym by banners

[kind gulch]

server banners

like from invites

[lone fable]

Oh hmm I guess that could be done but it's kinda niche
Isn't there already a plugin that allows opening an icon/banner in an image gallery? That would make it easier to directly patch the gallery instead of an invite component without breaking anything

[main river]

do you mean ViewIcons?

vp iconv

[kindred cobalt]

Couldn't find a plugin with that name, and there are no plugins with similar names.

[main river]

ough wrong name

vp viewic

[lone fable]

yeah yeah I forgot the name

I might be stupid but it looks like it doesn't have an option to view invite assets in a gallery view 😭

[lone fable]

works now
https://git.nin0.dev/userplugins/favouriteAnything/pulls/7

[quartz basin]

this plugin so good it saves on discord mobile

i can't send proof but i have a zip file in my regular discord's favorites

[lone fable]

[quartz basin]

i like it

[vocal rose]

https://tenor.com/view/he-made-a-statement-so-truthful-liam-gallagher-oasis-gif-16531291394258895783

Embed fail

😔

[quartz basin]

😭

[lone fable]

TODO: add support for message components (specifically the gallery thing and inline files) #🌺-regulars message

[sinful bison]

@lone fable i dont get it, does this plugin work? and if it does then what are the steps i have to do to get it

[lone fable]

Do you have the plugin installed?

https://discord.com/channels/1015060230222131221/1257038407503446176

[sinful bison]

nope, i was just asking about it in vencord help

[lone fable]

Follow these steps, this is required for installing any user plugin

As an alternative, you can also get the plugin on Equicord, where it's included in the preinstalled plugins

[sinful bison]

what is equicord 😭

[lone fable]

It's a vencord fork with a bunch of extra plugins added by default

[sinful bison]

is it.. safe?

[lone fable]

Hard to say, but I've never heard of any security issues on equi

[sinful bison]

i think im gonna try getting git and pnpm or wtv its called

[lone fable]

mhm

[sinful bison]

@lone fable check dms i asked u a question

[lone fable]

I just found out that the feature where unfavouriting a gif doesn't immediately hide it is probably a bug in favGifSearch
I tried to replicate that behavior for the files tab because I thought that's how it's supposed to work

[quartz basin]

oh.. it's sad because it's not a bad feature

[lone fable]

I think we can keep it this way, dw
hopefully favgifsearch never fixes it either

[quartz basin]

yayyy

[tranquil crystal]

https://tenor.com/view/bounce-advertising-meme-gif-26846884